Welcome @kameshsampath!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @kameshsampath. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Can one of the admins verify this patch?

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kameshsampath
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

/ok-to-test

Error: running mkcmp: exit status 1

Do you mind putting some examples of using this ?

yes I can do that I have working example folder which users can refer to

@medyagh and @tstromberg - the PR is updated with README and usage. Please review and merge

We need to handle the reversal of things done by add-on, we shall take that as separate issue .

All Times minikube: [ 92.929873 92.385825 92.650600]
All Times Minikube (PR 6657): [ 90.921868 94.616252 94.975845]

Average Minikube (PR 6657): 93.504655
Average minikube: 92.655433

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6657) |
+----------------------+-----------+--------------------+
| minikube v           |  0.147763 |           0.197063 |
| Creating kvm2        | 20.225015 |          20.973315 |
| Preparing Kubernetes | 49.276671 |          50.045426 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.403348 |          20.306530 |
| Waiting for cluster  |  0.054069 |           0.069658 |
+----------------------+-----------+--------------------+

/ok-to-test

All Times minikube: [ 67.880970 60.074232 61.744346]
All Times Minikube (PR 6657): [ 94.054838 92.374125 93.666554]

Average Minikube (PR 6657): 93.365172
Average minikube: 63.233183

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6657) |
+----------------------+-----------+--------------------+
| minikube v           |  0.185397 |           0.124679 |
| Creating kvm2        | 39.146173 |          20.594608 |
| Preparing Kubernetes |  0.721178 |          49.184763 |
| Pulling images       |           |                    |
| Launching Kubernetes | 19.796392 |          21.436350 |
| Waiting for cluster  |  0.064733 |           0.397971 |
+----------------------+-----------+--------------------+

Thank you!